Skip to content

fix: Invalid calculations in split mesh #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 20, 2025
Merged

fix: Invalid calculations in split mesh #180

merged 3 commits into from
Nov 20, 2025

Conversation

@alexbenedicto
Copy link
Collaborator

@alexbenedicto alexbenedicto commented Nov 19, 2025

Closes #179

This PR aims at:

  • correcting an invalid formula for the number of cells created when refining them
  • fixing invalid docstrings for some functions
  • add 2 test cases with a polyhedral mesh and a polygonal mesh to verify the count of the new created cells

@alexbenedicto alexbenedicto self-assigned this Nov 19, 2025
@paloma-martinez paloma-martinez merged commit a0222b7 into main Nov 20, 2025
50 checks passed
@paloma-martinez paloma-martinez deleted the benedicto/fix/invalid_calculations_in_SplitMesh branch November 20, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paloma-martinez paloma-martinez paloma-martinez approved these changes

@bd713 bd713 bd713 approved these changes

@RomainBaville RomainBaville RomainBaville approved these changes

Assignees

@alexbenedicto alexbenedicto

Labels

flag: ready for review flag: ready to merge type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid counting calculations in SplitMesh filter

5 participants

@alexbenedicto @paloma-martinez @bd713 @RomainBaville